feat(core): run commands directly #21918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 754ddf0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
xiongemi
force-pushed
the
feature/nxc-147-run-commands-directly-instead-of-via-run-executorjs
branch
from
8470a6f to
2202894
Compare
xiongemi
force-pushed
the
feature/nxc-147-run-commands-directly-instead-of-via-run-executorjs
branch
from
2202894 to
579f669
Compare
xiongemi
force-pushed
the
feature/nxc-147-run-commands-directly-instead-of-via-run-executorjs
branch
from
579f669 to
55c4e36
Compare
xiongemi
force-pushed
the
feature/nxc-147-run-commands-directly-instead-of-via-run-executorjs
branch
from
55c4e36 to
65d9841
Compare
xiongemi
force-pushed
the
feature/nxc-147-run-commands-directly-instead-of-via-run-executorjs
branch
from
65d9841 to
192fe8f
Compare
xiongemi
force-pushed
the
feature/nxc-147-run-commands-directly-instead-of-via-run-executorjs
branch
from
192fe8f to
a84fec3
Compare
xiongemi
force-pushed
the
feature/nxc-147-run-commands-directly-instead-of-via-run-executorjs
branch
from
a84fec3 to
c2ec654
Compare
xiongemi
force-pushed
the
feature/nxc-147-run-commands-directly-instead-of-via-run-executorjs
branch
from
c2ec654 to
eb6a1eb
Compare
xiongemi
force-pushed
the
feature/nxc-147-run-commands-directly-instead-of-via-run-executorjs
branch
from
eb6a1eb to
b4f82fb
Compare
xiongemi
force-pushed
the
feature/nxc-147-run-commands-directly-instead-of-via-run-executorjs
branch
from
b4f82fb to
2afcb4a
Compare
xiongemi
force-pushed
the
feature/nxc-147-run-commands-directly-instead-of-via-run-executorjs
branch
from
2afcb4a to
10e906b
Compare
xiongemi
force-pushed
the
feature/nxc-147-run-commands-directly-instead-of-via-run-executorjs
branch
from
10e906b to
2a50a8c
Compare
xiongemi
force-pushed
the
feature/nxc-147-run-commands-directly-instead-of-via-run-executorjs
branch
from
2a50a8c to
208f165
Compare
xiongemi
force-pushed
the
feature/nxc-147-run-commands-directly-instead-of-via-run-executorjs
branch
from
208f165 to
ba43924
Compare
xiongemi
force-pushed
the
feature/nxc-147-run-commands-directly-instead-of-via-run-executorjs
branch
from
6eb387d to
cccf921
Compare
xiongemi
force-pushed
the
feature/nxc-147-run-commands-directly-instead-of-via-run-executorjs
branch
from
cccf921 to
66873a8
Compare
xiongemi
force-pushed
the
feature/nxc-147-run-commands-directly-instead-of-via-run-executorjs
branch
from
66873a8 to
9b8e52d
Compare
xiongemi
force-pushed
the
feature/nxc-147-run-commands-directly-instead-of-via-run-executorjs
branch
from
9b8e52d to
537c637
Compare
xiongemi
force-pushed
the
feature/nxc-147-run-commands-directly-instead-of-via-run-executorjs
branch
from
537c637 to
07babc7
Compare
xiongemi
force-pushed
the
feature/nxc-147-run-commands-directly-instead-of-via-run-executorjs
branch
from
07babc7 to
ab2318b
Compare
xiongemi
force-pushed
the
feature/nxc-147-run-commands-directly-instead-of-via-run-executorjs
branch
7 times, most recently
from
7c06e84 to
42c3617
Compare
FrozenPandaz
approved these changes
Mar 11, 2024
| ); | ||
| if (targetConfiguration.executor === 'nx:run-commands' && !shouldPrefix) { |
There was a problem hiding this comment.
Add an environment variable to opt out for now, NX_RUN_COMMANDS_DIRECTLY !== 'false'
We'll remove it once we're sure it works.
xiongemi
force-pushed
the
feature/nxc-147-run-commands-directly-instead-of-via-run-executorjs
branch
from
42c3617 to
b6b64ea
Compare
xiongemi
force-pushed
the
feature/nxc-147-run-commands-directly-instead-of-via-run-executorjs
branch
from
b6b64ea to
754ddf0
Compare
xiongemi
dismissed
Cammisuli’s stale review
update the pr and address the request
FrozenPandaz
approved these changes
Mar 12, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #